Skip to content

Conversation

@elchupanebrej
Copy link
Contributor

@elchupanebrej elchupanebrej commented Jun 28, 2023

🤔 What's changed?

Added support of Python language as part of an integration with https://github.com/elchupanebrej/pytest-bdd-ng

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@elchupanebrej elchupanebrej marked this pull request as draft June 30, 2023 10:06
@elchupanebrej elchupanebrej marked this pull request as ready for review June 30, 2023 10:49
@elchupanebrej
Copy link
Contributor Author

Linter fixups are not relevant for python implementation and are moved into separate PR: #210

@elchupanebrej
Copy link
Contributor Author

Build fixed: elchupanebrej#1
Please re-run workflows

Copy link
Member

@blaisep blaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this because it is a net gain with no impact on previous features.

Note:

The README indicates support for Azure pipelines only. In fact, this can support GitHub actions and other CI systems.

@blaisep blaisep merged commit 225aaf6 into cucumber:main Jul 5, 2023
@aslakhellesoy
Copy link
Contributor

Hi @elchupanebrej,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

working-directory: ./python
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blaisep can you remove this file from main and resubmit it in a PR?

We currently don't have anything to publish to PyPI. Once that is setup the PR to enable python releases can be made.

@mpkorstanje mpkorstanje mentioned this pull request Jul 7, 2023
5 tasks
@mpkorstanje mpkorstanje mentioned this pull request Dec 8, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants